Open
Conversation
cp -r instead of mv, as windows tend to be messy with directories and renders them as "busy"
judovana
reviewed
Mar 11, 2026
| mv ${SCRIPT_DIR}/test.${TIME} . | ||
| cp -r ${SCRIPT_DIR}/test.${TIME} . | ||
| rm -rf ${SCRIPT_DIR}/test.${TIME} | ||
| mv -v ${SCRIPT_DIR}/test.${TIME}.tar.gz . || echo "Moving of results tarball failed" |
Collaborator
There was a problem hiding this comment.
There is second mv. That is not making troubles? It is || "always ok", but still we want that tarball...
Maybe add if cgwing them cp/rm else mv?
Collaborator
There was a problem hiding this comment.
This issue would be more spread over our suites.. Especially security reproducers. Long live duplicated code.. :(
judovana
reviewed
Mar 11, 2026
| $envVarArg \ | ||
| $FOLDER | tee test.${TIME}/tests.log || r=$? | ||
|
|
||
| tar -czf test.${TIME}.tar.gz "${jtWork}" "${jtReport}" || echo "Packing of results tarball failed" |
Collaborator
There was a problem hiding this comment.
Isn't the permission issue occurring already during tarirng? Maybe we can tar directly to the palce we mv to?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp -r instead of mv, as windows tend to be messy with directories and renders them as "busy"