set params::validate default value of plugin_dir to undef.#17
Open
omcnet wants to merge 1 commit into
Open
Conversation
Without this patch the bacula class's default value of undef, will not be used, since undef does not overwrite a parameter. Thus the params::validate default value for plugin_dir will be used, which is ''. This causes the validation to fail since '' is not a valid and absolute path. To fix this behaviour, the default value for plugin_dir within the params::validate class should also be undef, to work with the != undef condition within the class. The error will be triggered if a bacula class is created without setting the plugin_dir argument. The resulting error message is: valuation Error: Error while evaluating a Function Call, is not an absolute path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch the bacula class's default value of undef, will not be used, since undef does not overwrite a parameter.
Thus the params::validate default value for plugin_dir will be used, which is ''.
This causes the validation to fail since '' is not a valid and absolute path.
To fix this behaviour, the default value for plugin_dir within the params::validate class should also be undef, to work
with the != undef condition within the class.
The error will be triggered if a bacula class is created without setting the plugin_dir argument.
The resulting error message is:
valuation Error: Error while evaluating a Function Call, is not an absolute path.