fix: revert workflow image tags to osl_1_37 (images never pushed)#791
Open
hardengl wants to merge 1 commit into
Open
fix: revert workflow image tags to osl_1_37 (images never pushed)#791hardengl wants to merge 1 commit into
hardengl wants to merge 1 commit into
Conversation
The osl_1_38 images were never built and pushed to quay.io/orchestrator/, causing ImagePullBackOff on all workflow pods. This has broken every ROS nightly CI job since June 19. Missing images: - quay.io/orchestrator/fail-switch:osl_1_38 - quay.io/orchestrator/serverless-workflow-greeting:osl_1_38 - quay.io/orchestrator/serverless-workflow-sample-retry-test:osl_1_38 - quay.io/orchestrator/serverless-workflow-test-object-type-uiprops:osl_1_38 The build.sh script was correctly updated to use the 1.38.0 builder, but the resulting images need to be built and pushed before manifests can reference them. Reverts manifest-only changes from 2c8de41. Requested-By: <@UTKKVT884> (gharden)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
osl_1_38images were never built and pushed toquay.io/orchestrator/Root Cause
Commit 2c8de41 correctly updated
build.shto use the OSL 1.38.0 builder, but also updated manifest image tags to reference:osl_1_38— images that don't exist on Quay.io. This causesImagePullBackOffon failswitch pods, which fails thedeploy-test-workflows.shstep.Missing images
quay.io/orchestrator/fail-switch:osl_1_38❌quay.io/orchestrator/serverless-workflow-greeting:osl_1_38❌quay.io/orchestrator/serverless-workflow-sample-retry-test:osl_1_38❌quay.io/orchestrator/serverless-workflow-test-object-type-uiprops:osl_1_38❌What this PR does
Reverts the 4 manifest files back to
:osl_1_37which exists and works. Thebuild.shchanges are kept — once images are built with the new builder and pushed, manifests can be updated.Test plan
osl_1_37tags exist on Quay.io🤖 Generated with Claude Code