Skip to content

feat: to ConfigId helper#127

Open
Dhruv-Mishra wants to merge 11 commits intorhinestonewtf:mainfrom
Dhruv-Mishra:feat/toConfigIdHelper
Open

feat: to ConfigId helper#127
Dhruv-Mishra wants to merge 11 commits intorhinestonewtf:mainfrom
Dhruv-Mishra:feat/toConfigIdHelper

Conversation

@Dhruv-Mishra
Copy link
Copy Markdown
Contributor

As discussed in #109

@Dhruv-Mishra Dhruv-Mishra mentioned this pull request Feb 2, 2025
3 tasks
@Dhruv-Mishra Dhruv-Mishra changed the title Feat/to config id helper To ConfigId Helper Feb 2, 2025
@Dhruv-Mishra Dhruv-Mishra changed the title To ConfigId Helper feat: to ConfigId helper Feb 2, 2025
@Dhruv-Mishra
Copy link
Copy Markdown
Contributor Author

@kopy-kat requesting review on this

Comment thread src/module/smart-sessions/policies/utils.ts
Comment thread src/module/smart-sessions/policies/utils.ts
@Dhruv-Mishra
Copy link
Copy Markdown
Contributor Author

@kopy-kat added functions as per your review

If this looks good to you, can you squash the commits before merging, I created multiple commits to fix unwanted file changes due to EOL spaces 😅

Copy link
Copy Markdown
Member

@kopy-kat kopy-kat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants