Support composes that have '-FULL-' or other suffix after product in ID#95
Merged
Conversation
PLukas2018
reviewed
Jun 30, 2026
PLukas2018
left a comment
PLukas2018
left a comment
Collaborator
There was a problem hiding this comment.
Hopefully it will not break anything 😅 .
Maybe you could add test for the new ids in
https://github.com/rhinstaller/permian/blob/devel/libpermian/plugins/compose/test_compose.py#L70
if the tests are used and relevant or at least add comment of example ID to the code.
Also maybe we could add comment that the variant is not saved as it is not used anywhere right now.
Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.