Skip to content

fix: add a guardrail for TSDB requirement#45

Closed
tremes wants to merge 1 commit intorhobs:mainfrom
tremes:obsinta-1177
Closed

fix: add a guardrail for TSDB requirement#45
tremes wants to merge 1 commit intorhobs:mainfrom
tremes:obsinta-1177

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Mar 11, 2026

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tremes
Once this PR has been reviewed and has the lgtm label, please assign xiormeesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes tremes marked this pull request as ready for review March 12, 2026 09:01
@tremes tremes requested a review from a team March 12, 2026 09:01
@openshift-ci openshift-ci bot requested review from iNecas and saswatamcode March 12, 2026 09:01
@iNecas
Copy link
Contributor

iNecas commented Mar 12, 2026

Works for me. @saswatamcode any objections?

@saswatamcode
Copy link
Member

Not blocking here, but is this really a guardrail?
To me, a guardrail is something that blocks or guides the LLM away from certain actions.

Looks like this guardrail is more a workaround for categorizing other guardrails?

How about instead we have some guardrail type like

type Guardrail struct {
    Name string
    RequiresTSDBEndpoint bool
}

And refactor a bit so our Guardrails type is basically a slice of []Guardrail?
So, certain guardrails of type TSDB (or Cardinality?) can be disabled via some flag?

Wdyt @tremes @iNecas?

Again not blocking, if this is needed for urgent testing, fine to merge and iterate :)

@tremes
Copy link
Contributor Author

tremes commented Mar 13, 2026

@saswatamcode I tried the alternative with using map of gurardrails (I think it's better for lookup) #47, but not sure if it's not too much & too much verbose.

@tremes
Copy link
Contributor Author

tremes commented Mar 16, 2026

Closing in favor of #47

@tremes tremes closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants