Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tremes The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Works for me. @saswatamcode any objections? |
|
Not blocking here, but is this really a guardrail? Looks like this guardrail is more a workaround for categorizing other guardrails? How about instead we have some guardrail type like type Guardrail struct {
Name string
RequiresTSDBEndpoint bool
}And refactor a bit so our Again not blocking, if this is needed for urgent testing, fine to merge and iterate :) |
|
@saswatamcode I tried the alternative with using map of gurardrails (I think it's better for lookup) #47, but not sure if it's not too much & too much verbose. |
|
Closing in favor of #47 |
No description provided.