Skip to content

fix: prometheus client - use service-ca file for TLS#50

Merged
openshift-merge-bot[bot] merged 1 commit intorhobs:mainfrom
tremes:my-main
Mar 17, 2026
Merged

fix: prometheus client - use service-ca file for TLS#50
openshift-merge-bot[bot] merged 1 commit intorhobs:mainfrom
tremes:my-main

Conversation

@tremes
Copy link
Contributor

@tremes tremes commented Mar 17, 2026

I came across this when I was experimenting with openshift/openshift-mcp-server#124 when I was facing the unsigned cert issue when calling get_alerts tool.

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@iNecas
Copy link
Contributor

iNecas commented Mar 17, 2026

makes sense, is consistent with the configuration we do in

defaultServiceAccountCAPath = "/var/run/secrets/kubernetes.io/serviceaccount/service-ca.crt"

@tremes tremes marked this pull request as ready for review March 17, 2026 14:35
@tremes tremes requested a review from a team March 17, 2026 14:35
@openshift-ci openshift-ci bot requested review from rexagod and slashpai March 17, 2026 14:35
@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iNecas, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@iNecas
Copy link
Contributor

iNecas commented Mar 17, 2026

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit b216ccb into rhobs:main Mar 17, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants