Wire vendor_exprtk --check into CI; re-pin BNGsim expr layer to public lanl/bngsim (#11) - #22
Merged
Merged
Conversation
…ift-check (#11) The ExprTk swap (#6) vendored four files from BNGsim under third_party/, pinned by third_party/bngsim_expr/VENDOR{,.json}. That pin referenced a commit on the retired private wshlavacek/PyBNF-Private monorepo, where BNGsim lived under a bngsim/ subdir. BNGsim is now published standalone at the public lanl/bngsim, whose history does not carry the old private commit, so scripts/vendor_exprtk.py --check --bngsim-repo could never point at a live public commit. Re-pin to lanl/bngsim@5ce19a4: - Two of the four files advanced upstream and were refreshed to match the new pin: expression.hpp/.cpp gain a tgamma builtin (SBML factorial) and a referenced_variable_addresses accessor (BNGsim forward-sensitivity, GH #212). Neither is used by RM; the rest is clang-format only. Behavioral no-op for RM, confirmed by the full 80-model feature-coverage suite (80 PASS / 0 FAIL at --reps 5) and the 26-test unit suite. - vendor_exprtk.py records repo_subdir "." (lanl/bngsim is the repo root, not a bngsim/ subdir); VENDOR/VENDOR.json now cite the public remote. Wire the guard into CI: a new vendor_check job clones lanl/bngsim (public, no credential) with full history and runs the source drift-check, failing the build on any skew between RM's standalone copy and BNGsim's expression layer (an ODR hazard). This was the only thing blocked on BNGsim going public; the private source repo would have needed a stored deploy key. Patch bump 3.6.0 -> 3.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11.
Context
The blocker in #11 — "unblocks when PyBNF-Private goes public" — is now resolved, but not the way the issue anticipated. PyBNF-Private was retired, and BNGsim was republished standalone at the public
lanl/bngsimas a fresh repo (50 commits, "Initial public release" 2026-07-04). The old private history was not migrated, so the vendored pin (wshlavacek/PyBNF-Private@1a1d49da, on abngsim/subdir) points at a commit that does not exist publicly. A--check --bngsim-repostep againstlanl/bngsimwith the old pin would fail on a missing git object.So wiring a working source drift-check required re-pinning to a live public commit first.
Changes
Re-pin to
lanl/bngsim@5ce19a4(third_party/bngsim_expr/VENDOR{,.json},scripts/vendor_exprtk.py)exprtk.hppandexpr_compat.hppwere byte-identical upstream — untouched.expression.hpp/expression.cppadvanced upstream and were refreshed to match the new pin: they gain atgammabuiltin (SBML factorial) and areferenced_variable_addressesaccessor (BNGsim forward-sensitivity, GH #212). Neither is used by RuleMonkey; the remainder is clang-format only.bngsimsubdir (repo_subdir: ".").New CI job
vendor_check(.github/workflows/ci.yml)lanl/bngsim(public, no credential) withfetch-depth: 0so the pinned commit stays reachable after HEAD advances, then runsscripts/vendor_exprtk.py --check --bngsim-repo bngsim. Drift fails the build (ODR hazard). Independent, build-free, stdlib-only Python.Patch bump 3.6.0 → 3.6.1 + CHANGELOG.
Verification
vendor_exprtk.py --checkand--check --bngsim-repoboth green against the new pin.--reps 5— the file refresh is a behavioral no-op for RM.exclude: '^third_party/').