This repository was archived by the owner on Aug 7, 2025. It is now read-only.
This forces the vmaf comparison colorspace, otherwise its assume the …#24
Open
richardssam wants to merge 1 commit intomainfrom
Open
This forces the vmaf comparison colorspace, otherwise its assume the …#24richardssam wants to merge 1 commit intomainfrom
richardssam wants to merge 1 commit intomainfrom
Conversation
…source colorspace is rec601 (I think).
Collaborator
|
I've been assuming that since both source's color spaces should match, that the vmaf would be able to compare properly, but haven't spent much time looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…source colorspace is rec601 (I think).
I'm not 100% sure we want to do it this way, but I'm pretty sure this is wrong since otherwise ffmpeg will treat any sourceimages as having the wrong colorspace.