fix(shell): set programs.fish.enable when cfg.fish.enable is true#128
fix(shell): set programs.fish.enable when cfg.fish.enable is true#128richen604 merged 9 commits intorichen604:mainfrom
Conversation
Added conditional check and enable in /hydenix/modules/hm/shell.nix
|
what is the default fish file that is created when the home-manager module is enabled? does it conflict with hyde defaults? im assuming it makes a |
Add conditional fastfetch display to fish shell's interactiveShellInit section, matching the existing zsh implementation. Fastfetch will only run when cfg.fastfetch.enable is true.
- Add eza to fish packages list to support fish aliases - eza is used for directory listing aliases in Hyde's fish config - Ensures consistency with zsh configuration which already includes eza
Remove duplicate package declarations when both zsh and fish are enabled. Also removed unneeded fzf pkg as it is declared elsewhere in hydenix.
Home Manager's programs.fish module generates and manages config.fish. Direct file copying causes conflicts. This is step 1 of proper fish integration with Home Manager.
Add the eza-based directory listing aliases (l, ls, ll, ld, lt) and the vc alias for VS Code. These are the exact aliases from Hyde's original config.fish.
Add conditional initialization for: - Starship prompt with proper environment variables - Pokego ASCII art (when enabled) - Fastfetch system info (when enabled) - Source hyde_config.fish for additional Hyde customizations All features respect their respective enable flags.
Add `set -g fish_greeting` to disable the default fish greeting, matching Hyde's original config.fish behavior.
|
Thank you for the direction. After reviewing home-manage fish module, and utilizing the options seems to be the best way to mitigate the conflict you identified. I need to do more testing before updating the PR, but would appreciate feedback on if this approach is appropriate with your vision for this project or you would prefer a different implementation. Thank you for all your efforts and apologies for the extra review request. |
|
looks good! hydenix/hydenix/modules/hm/shell.nix Line 268 in 21c8104 |
stoutpanda
force-pushed
the
fix/fish-enable
branch
from
22d1fdc to
5381714
Compare
richen604
left a comment
richen604
left a comment
There was a problem hiding this comment.
looks great, ready to merge?
|
Good to merge. Looks good on my laptop and a vm with fish as default shell. Thanks for the help! |
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Added conditional check and enable in /hydenix/modules/hm/shell.nix
Description
Found that on a new install fish.pkg was not being installed when enabling it. Added conditional check for the option and enabled the package if the user uses the fish.enable option in shell.nix. Followed the existing zsh implementation style in the same file.
Type of change
Bug fix as nix-rebuild will not work if the fish pkg is not enabled somewhere.
Checklist