Skip to content

feat(shell/zsh): eval fzf && source hyde's shell functions#156

Merged
richen604 merged 2 commits intorichen604:mainfrom
Roverp1:source-shell-functions
Nov 7, 2025
Merged

feat(shell/zsh): eval fzf && source hyde's shell functions#156
richen604 merged 2 commits intorichen604:mainfrom
Roverp1:source-shell-functions

Conversation

@Roverp1
Copy link
Copy Markdown
Contributor

@Roverp1 Roverp1 commented Sep 26, 2025

Description

Source all .zsh files from functions and completions directories

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My commits follow conventional commit format
  • I have updated the documentation accordingly
  • My changes generate no new warnings

@Roverp1 Roverp1 force-pushed the source-shell-functions branch 2 times, most recently from faebf04 to 1568b73 Compare September 26, 2025 17:18
Comment thread hydenix/modules/hm/shell.nix Outdated
".config/zsh/functions/duf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/duf.zsh";
".config/zsh/functions/error-handlers.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/error-handlers.zsh";
".config/zsh/functions/eza.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/eza.zsh";
".config/zsh/functions/fzf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/fzf.zsh";
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets include fzf to easier track changes on hyde update
means we can remove this and the df function because it becomes included by sourcing all files

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I've also removed aliases as they also getting defined by sourcing files

Comment thread hydenix/modules/hm/shell.nix Outdated
@@ -362,10 +378,10 @@ in
".config/zsh/functions/duf.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/duf.zsh";
".config/zsh/functions/error-handlers.zsh".source = "${pkgs.hydenix.hyde}/Configs/.config/zsh/functions/error-handlers.zsh";
Copy link
Copy Markdown
Owner

@richen604 richen604 Sep 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error-handlers needs to go actually because it has too much arch specific code
tbh i dont think ive ever had this call so that can go too

@richen604
Copy link
Copy Markdown
Owner

ill resolve these conflicts at some point or you can take a stab at it, meant to merge these changes before 5.0

@Roverp1 Roverp1 force-pushed the source-shell-functions branch from 49f07f0 to 4144e07 Compare November 7, 2025 10:36
@Roverp1
Copy link
Copy Markdown
Contributor Author

Roverp1 commented Nov 7, 2025

ill resolve these conflicts at some point or you can take a stab at it, meant to merge these changes before 5.0

Finally got some time to look into it. Did a rebase to upstream/main

@richen604
Copy link
Copy Markdown
Owner

looks good! tested it locally myself
this also fixes eza working correctly lol, i just never got around to it

@richen604 richen604 merged commit d4d06d3 into richen604:main Nov 7, 2025
2 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 7, 2025

🎉 This PR is included in version 5.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Roverp1 Roverp1 deleted the source-shell-functions branch November 7, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants