Fix unhandled rejection error from visibility change events#158
Open
joshkel wants to merge 1 commit intorichtr:masterfrom
Open
Fix unhandled rejection error from visibility change events#158joshkel wants to merge 1 commit intorichtr:masterfrom
joshkel wants to merge 1 commit intorichtr:masterfrom
Conversation
Visibility change events could result in unhandled rejection errors. I believe that NoSleep.js should suppress them, since there isn't anything that callers can do about it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Visibility change events may cause unhandled rejection errors. This creates extra console noise and may trigger spurious errors in error-reporting services like Sentry.
Breaking Changes
None.
Additional Info
I believe that NoSleep.js should suppress any errors thrown from visibility change events, since there isn't anything that callers can do about them.