fix(lu): Nationalfeierdag on 23rd June - #155
Merged
Merged
Conversation
According to https://luxembourg.public.lu/en/living/quality-of-life/jours-feries-legaux.html Luxembourg's national day is on 23rd June instead of 23rd July. The 23rd June has been the national day since 1961 https://en.wikipedia.org/wiki/Grand_Duke%27s_Official_Birthday#Development_of_the_holiday
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luxembourg's National Day (Nationalfeierdag) is celebrated on 23 June, not 23 July.
Per the official Luxembourg government page, the national day falls on 23 June. It has been fixed to this date since 1961 (see Grand Duke's Official Birthday).
This corrects the month in
v2/lu/lu_holidays.goand updates the corresponding tests.