Adventofcode Pull Request by Karla Tschavoll ET-Dual#1
Open
phiMale wants to merge 9 commits intoriederm:mainfrom
Open
Adventofcode Pull Request by Karla Tschavoll ET-Dual#1phiMale wants to merge 9 commits intoriederm:mainfrom
phiMale wants to merge 9 commits intoriederm:mainfrom
Conversation
Owner
|
Hi Karla, thx for the PR - and yes you are correct - we cann access every old commit. We take a look at it in class and discuss some strategies on how you find errors in the future. |
riederm
reviewed
Oct 29, 2023
day01/day01_v2.py
Outdated
| return | ||
| else: | ||
| cumlsum_dict[line] = None | ||
| cumlsum_inputs += cumlsum_inputs[-1] |
Owner
There was a problem hiding this comment.
but cool that you followed a not-so-obvious idea here! 🥳
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Mathias,
this is my attempt at the two adventofcode2018 riddles. I wrote two separate solutions for day01, one of which didn't work. and I have no clue why. maybe we can discuss it in class. I deleted the file "day01_v2.py", but if I understood this git thing correctly, you should be able to access previous commits now, too. let me know.
CU karla
PS: you asked us which soft drinks we liked. I think I'll go with a coke :)