Open
Conversation
ADmad
requested changes
Dec 29, 2018
| 'append' => [], | ||
| 'saveOptions' => [] | ||
| 'saveOptions' => [], | ||
| 'preserveKeyFromCompositeKey' => '' |
Collaborator
There was a problem hiding this comment.
Why is this this a string, what if composite key consistents of 3 fields and 2 need to be removed?
| { | ||
| if (is_array($object->getPrimaryKey())) { | ||
|
|
||
| $compositeKey = $object->getPrimaryKey(); |
Collaborator
There was a problem hiding this comment.
Make this assignment the first statement (with name $primaryKey) and avoid calling method again.
dereuromark
reviewed
Dec 30, 2018
| * | ||
| * @param EntityInterface $entity | ||
| * @param $object | ||
| * @throws \Exception |
Contributor
There was a problem hiding this comment.
return void missing maybe here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for duplicating tables with composite keys