Skip to content

chore: publish to internal crate registry#2

Merged
BatmanAoD merged 12 commits into
rigetti-mainfrom
publish-tracing-error-to-rigetti-cargo
Jun 17, 2026
Merged

chore: publish to internal crate registry#2
BatmanAoD merged 12 commits into
rigetti-mainfrom
publish-tracing-error-to-rigetti-cargo

Conversation

@BatmanAoD

@BatmanAoD BatmanAoD commented May 29, 2026

Copy link
Copy Markdown
Collaborator

This uses an internal GitLab mirror to run CI, including the publish step.

The first commit, d9d4c542, is from the upstream main branch.

To see that the new job is working, and that a prerelease is published to rigetti-cargo: find "Trigger GitLab CI / Trigger GitLab pipeline (pull_request)" in the list of checks, then look at the log for that check and click through to the linked GitLab CI pipeline.

The initial release after this is merged will not succeed, because, as part of testing this, I already published version 0.2.1 to CodeArtifact. In order to publish the next version, we will need to manually bump it as part of #1 and/or #3.

@BatmanAoD BatmanAoD force-pushed the publish-tracing-error-to-rigetti-cargo branch from 5abb495 to dc25a00 Compare May 29, 2026 23:23
@BatmanAoD BatmanAoD marked this pull request as ready for review May 29, 2026 23:49

@windsurf-bot windsurf-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

💡 To request another review, post a new comment with "/windsurf-review".

## Motivation

CI `warnings` job (clippy) is failing with `error: manual implementation of "Option::zip"` for Rust 1.96.0.
e.g. https://github.com/tokio-rs/tracing/actions/runs/25983660191/job/78456844423?pr=3534

```
error: manual implementation of `Option::zip`
   --> tracing-error/src/backtrace.rs:208:41
    |
208 |               if let Some((file, line)) = metadata
    |  _________________________________________^
209 | |                 .file()
210 | |                 .and_then(|file| metadata.line().map(|line| (file, line)))
    | |__________________________________________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.96.0/index.html#manual_option_zip
    = note: `-D clippy::manual-option-zip` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::manual_option_zip)]`
help: use
    |
208 ~             if let Some((file, line)) = metadata
209 +                 .file().zip(metadata.line())
```


## Solution

Apply the suggestion by Clippy and format the code (cargo fmt --all).
@BatmanAoD BatmanAoD force-pushed the publish-tracing-error-to-rigetti-cargo branch 3 times, most recently from 0c9d75a to 58db907 Compare June 15, 2026 20:11
@BatmanAoD BatmanAoD mentioned this pull request Jun 15, 2026
@BatmanAoD BatmanAoD force-pushed the publish-tracing-error-to-rigetti-cargo branch 3 times, most recently from 71025b9 to 1bec96b Compare June 15, 2026 21:59
@BatmanAoD BatmanAoD force-pushed the publish-tracing-error-to-rigetti-cargo branch from 394dd90 to b95a0d2 Compare June 16, 2026 04:48
Comment thread tracing-error/src/backtrace.rs
@BatmanAoD BatmanAoD merged commit 91ad9a2 into rigetti-main Jun 17, 2026
49 of 53 checks passed
@BatmanAoD BatmanAoD deleted the publish-tracing-error-to-rigetti-cargo branch June 17, 2026 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants