fix: bugs, type definitions, and test coverage#71
Open
rililive wants to merge 2 commits into
Open
Conversation
- Fix null reference crash in PhoneInput.updateValue when countryData is undefined - Fix Android back button not closing country picker modal (onRequestClose) - Replace deprecated substr() with substring() in PhoneInput and PhoneNumber - Remove componentDidUpdate anti-pattern; use props.disabled directly - Use nullish coalescing (??) for priority in country.tsx - Fix type definitions: cancelTextStyle optional, getAllCountries/getPickerData return arrays - Remove unused prop-types dependency - Remove console.log from production code in PhoneNumber.parse - Add comprehensive tests for PhoneNumber and Country classes (3 → 42 tests) - Add eslint override for no-unused-expressions in test files https://claude.ai/code/session_015viBaeA5T6gX1bKKNty4hV
- Use specific lodash imports (first, findKey) instead of full library import - Remove unused countries.json import from PhoneNumber.tsx - Remove dead picker ref and unused index param from CountryPicker.tsx - Fix renderFlag type to use React.ReactElement and ImageRequireSource - Update typings header to reference current repo - Fix README: old repo links, deprecated string ref, function table errors - Remove onPressCancel/onPressConfirm from Functions table (they are props) - Add CLAUDE.md with project context and development commands https://claude.ai/code/session_015viBaeA5T6gX1bKKNty4hV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://claude.ai/code/session_015viBaeA5T6gX1bKKNty4hV