-
Notifications
You must be signed in to change notification settings - Fork 187
feat: define explore dashboards inline in metrics views via the explore: block
#9680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nishantmonu51
wants to merge
4
commits into
main
Choose a base branch
from
explore_as_mv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
55cfa0d
feat: define explore dashboards inline in metrics views
nishantmonu51 531664a
feat: clearer CTA labels on inline-explore metrics views: "Preview Ex…
nishantmonu51 ee4ca38
Merge remote-tracking branch 'origin/main' into explore_as_mv
nishantmonu51 4a7fcb2
Merge remote-tracking branch 'origin/main' into explore_as_mv
nishantmonu51 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -258,3 +258,41 @@ export const useGetExploresForMetricsView = ( | |
| (res) => res.explore?.spec?.metricsView === metricsViewName, | ||
| ); | ||
| }; | ||
|
|
||
| // Canvases don't reference metrics views directly: their rows contain components, | ||
| // and each component's renderer properties name the metrics view it queries. | ||
| export const useGetCanvasesForMetricsView = ( | ||
| client: RuntimeClient, | ||
| metricsViewName: string, | ||
| ) => { | ||
| return createRuntimeServiceListResources( | ||
| client, | ||
| {}, | ||
| { | ||
| query: { | ||
| select: (data) => { | ||
| const componentNames = new Set( | ||
| data.resources | ||
| ?.filter( | ||
| (res) => | ||
| res.meta?.name?.kind === ResourceKind.Component && | ||
| res.component?.state?.validSpec?.rendererProperties | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just one way to get metrics view. There are other ways that runtime.ResolveCanvas in backend handles. So we would have to call ResolveCanvas on every canvas to get this reverse map. |
||
| ?.metrics_view === metricsViewName, | ||
| ) | ||
| .map((res) => res.meta?.name?.name), | ||
| ); | ||
| return ( | ||
| data.resources?.filter( | ||
| (res) => | ||
| res.meta?.name?.kind === ResourceKind.Canvas && | ||
| res.canvas?.state?.validSpec?.rows?.some((row) => | ||
| row.items?.some((item) => componentNames.has(item.component)), | ||
| ), | ||
| ) ?? [] | ||
| ); | ||
| }, | ||
| }, | ||
| }, | ||
| queryClient, | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we use the same UI for editing inline and explicit explores we should find a way to keep the parser code in sync. Maybe we can move explore definition specific fields to a new struct and move parsing there?