feat: Add custom algoforge-dark Monaco editor theme (closes #24)#62
feat: Add custom algoforge-dark Monaco editor theme (closes #24)#62arcgod-design wants to merge 2 commits into
Conversation
|
Someone is attempting to deploy a commit to the rishabhjtripathi2903-3434's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesCustom Monaco Theme Integration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/sections/ProblemWorkspace.tsx`:
- Around line 293-299: The icon-only theme toggle in ProblemWorkspace should
expose a proper accessible name instead of relying on title alone. Update the
button that calls setTheme in ProblemWorkspace to include an aria-label
describing the action (for example, toggle theme) and add aria-pressed to
reflect whether the current theme is active; keep the existing icon swap logic
intact so the control remains understandable to screen readers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 715aaaa8-e5ae-42c7-947a-ad10aa695b9e
📒 Files selected for processing (1)
app/src/sections/ProblemWorkspace.tsx
|
Addressed: added aria-label and aria-pressed to the theme toggle button for screen reader accessibility. Merge conflicts with upstream/main also resolved. PR body updated with all 10 tasks checked. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Thanks for adding the labels! Heads up on the Vercel deployment failure — it's not a code issue. The Vercel bot is blocking on team authorization:
To unblock the deploy, the team owner just needs to visit the auth link below once and click Authorize — Vercel will then auto-retry and the build can run: Once authorized, the build can run and any genuine build error (if any) will surface in the bot's output. CI / Lint & Type Check passed cleanly on this PR ✅ and codereview is approved ✅. |
|
Hey @Rishabhworkspace, this PR has been ready for review for a while -- offering this friendly bump. The implementation matches the issue's specified behavior and CI is passing. PR: #62 When you have a moment, a review would be much appreciated. I am happy to iterate on any feedback. If the timing is not right, no worries at all -- just a gentle nudge from a contributor who has been waiting patiently. � |
Related Issue
Closes #24
Description
Adds a custom
algoforge-darkMonaco editor theme that matches AlgoForge's design system. The editor background now matches the app's #141414 deep dark, keywords use #a088ff (purple accent), strings use #63e3ff (cyan accent), and comments are muted gray. The light theme toggle continues to work correctly.Type of Change
Screenshots
The editor background now matches the app's #141414 instead of the default #1e1e1e. Keywords, strings, and other tokens use the AlgoForge accent palette.
Checklist
Summary by CodeRabbit