Skip to content

Make leaderResignedChan buffered to protect against hang #1205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
Apr 14, 2026
+4 −2
Merged

Make leaderResignedChan buffered to protect against hang #1205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions internal/leadership/elector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,10 @@ func (e *Elector) Start(ctx context.Context) error {
return nil
}

// We'll send to this channel anytime a leader resigns on the key with `name`
e.leaderResignedChan = make(chan struct{})
// We'll send to this channel anytime a leader resigns on the key with `name`.
// Buffered to 1 so a send doesn't block if the receiving loop hasn't entered
// its select yet (e.g. between gaining and maintaining leadership).
e.leaderResignedChan = make(chan struct{}, 1)

e.requestResignChan = make(chan struct{})

Expand Down
Loading