Return correct value for base64 and empty strings#21
Open
aarong wants to merge 8 commits intorjrodger:masterfrom
aarong:master
Open
Return correct value for base64 and empty strings#21aarong wants to merge 8 commits intorjrodger:masterfrom aarong:master
aarong wants to merge 8 commits intorjrodger:masterfrom
aarong:master
Conversation
aarong
commented
Nov 17, 2011
- AWS returns base64 strings for attribute values that contain XML-restricted characters (such as \u0000) -- detect and decode these values.
- The XML parser used by aws-lib returns empty strings as {} -- check for these and return "" to the client.
added 8 commits
November 17, 2011 10:09
…stricted characters are present.
Owner
|
Hi Aaron - just trying to understand this pull request - do you have a test case for the problem it is solving? |
Owner
|
Sorry for the lack of action on my part - I made you a collaborator, so feel free to merge directly :) |
Collaborator
|
@aarong would like to know if this is addressed in later versions of aws-lib. Should we close this request or update it? |
Owner
|
I too out of the loop to comment, but note that I have made this project Open-Open: https://github.com/rvagg/node-levelup/blob/master/CONTRIBUTING.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.