Report scroll progress and show progress bar#28
Open
josephinoo wants to merge 1 commit intorkwyu:mainfrom
Open
Report scroll progress and show progress bar#28josephinoo wants to merge 1 commit intorkwyu:mainfrom
josephinoo wants to merge 1 commit intorkwyu:mainfrom
Conversation
Expose an in-page progress callback and hook it up to a CLI progress bar while processing pages. ScribdDownloader now starts a progress bar, exposes __onScrollProgress__ to the page, updates the bar during evaluation, and stops it when done. PuppeteerSg gains a protocolTimeout option and emits progress from its scrolling helper (container or window scrolling) via a reportProgress no-op fallback if the callback is absent, ensuring final progress is reported when scrolling completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose an in-page progress callback and hook it up to a CLI progress bar while processing pages. ScribdDownloader now starts a progress bar, exposes onScrollProgress to the page, updates the bar during evaluation, and stops it when done. PuppeteerSg gains a protocolTimeout option and emits progress from its scrolling helper (container or window scrolling) via a reportProgress no-op fallback if the callback is absent, ensuring final progress is reported when scrolling completes.