feat(osm-equity): add North America / US region bboxes#25
Conversation
…oxes Lets the study run at continent/national scale (regions previously fell back to the Oakland default bbox, which would mislabel the map). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds bounding boxes for "north america" and "united states" to the geographic utility dictionary. The review feedback suggests expanding the "north america" bounding box to include northern Canada and Greenland, and renaming "united states" to "conterminous united states" to accurately reflect that it excludes Alaska and Hawaii.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| "california": (-124.41, 32.53, -114.13, 42.01), | ||
| "los angeles, ca": (-118.67, 33.70, -118.16, 34.34), | ||
| "san francisco, ca": (-122.52, 37.70, -122.36, 37.83), | ||
| "north america": (-168.0, 5.0, -52.0, 72.0), |
There was a problem hiding this comment.
The bounding box for "north america" (-168.0, 5.0, -52.0, 72.0) excludes the high Arctic islands of northern Canada (which extend up to ~83° N) and Greenland (which is geographically part of North America and extends to ~83.6° N and -11.3° W). If the study is intended to cover the entire continent, consider expanding the bounding box limits to fully encompass these regions.
| "north america": (-168.0, 5.0, -52.0, 72.0), | |
| "north america": (-168.0, 5.0, -10.0, 84.0), |
| "los angeles, ca": (-118.67, 33.70, -118.16, 34.34), | ||
| "san francisco, ca": (-122.52, 37.70, -122.36, 37.83), | ||
| "north america": (-168.0, 5.0, -52.0, 72.0), | ||
| "united states": (-124.8, 24.4, -66.9, 49.4), |
There was a problem hiding this comment.
The bounding box provided for "united states" (-124.8, 24.4, -66.9, 49.4) specifically covers the Conterminous United States (CONUS), excluding Alaska and Hawaii. To prevent confusion and avoid potential issues when real TIGER tracts or national-scale datasets are integrated (as noted in the TODO(real) comments), consider renaming this key to "conterminous united states" to accurately reflect its geographic scope.
| "united states": (-124.8, 24.4, -66.9, 49.4), | |
| "conterminous united states": (-124.8, 24.4, -66.9, 49.4), |
1 participant
Adds
north americaandunited statesbounding boxes so the osm-equity study runs at continent/national scale instead of falling back to the Oakland default. ruff clean; 13 tests pass.🤖 Generated with Claude Code