Conversation
We do not run benchmarks as the container does not seem to let us run perf by default, and we don't care much to run benchmarks all the time anyway.
craff
reviewed
Jul 5, 2024
Collaborator
craff
left a comment
craff
left a comment
There was a problem hiding this comment.
Got, just one remark to add 5.2.0 to workflow, but not really necessary in this PR.
Owner
Author
I added it, could you approve the PR? Merging currently requires approval, but if that gets too annoying I'll disable this. |
Collaborator
|
I will approve when I am back home
Le 5 juillet 2024 13:09:01 GMT-10:00, Rodolphe Lepigre ***@***.***> a écrit :
…> Got, just one remark to add 5.2.0 to workflow, but not really necessary in this PR.
I added it, could you approve the PR? Merging currently requires approval, but if that gets too annoying I'll disable this.
--
Reply to this email directly or view it on GitHub:
#36 (comment)
You are receiving this because you were assigned.
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These versions are probably obsolete at this point, and this allows simplifying the code slightly.