bugfix #1919: Unix mount-aware disk-space preflight - #1922
Merged
Conversation
Path.GetPathRoot always returns "/" for absolute Unix paths, so bulk backup preflight queried composefs root free space (often 0 on Bazzite) instead of the filesystem containing Books/In progress. On Unix, symlink-canonicalize paths (so /home -> /var/home) and pick the longest DriveInfo.GetDrives() mount prefix. Route GetBackupDriveSpaces through the shared helper so grouping and free-space queries agree. Co-authored-by: rmcrackan <rmcrackan@gmail.com>
github-actions
Bot
added
the
exempt
FindLongestMountPointPrefix is exercised on Windows CI with Unix-style paths. Path.DirectorySeparatorChar is '\\' there, so '/var/home' never matched '/var/home/...'. Hardcode '/' for Unix mount identity. Co-authored-by: rmcrackan <rmcrackan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1919: false "Not enough disk space"
/home->/var/home), then take the longest matchingDriveInfo.GetDrives()mount prefix