Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brenna Wells recently had a seg fault running Piff. The problem turned out to be the GSObject solver going to scale < 0 in one of the iterations, which blew up the memory when trying to draw it. I fixed this by guarding against negative scales in the fitting process (similar to how we already guard against |g| >= 1).
Another part of the problem was that this object had pretty low S/N. So this PR also adds a check for "good" stars that have nominal snr <= 0 and adds a logger warning that the user might want to include a min_snr selection.