chore(deps): bump lucide-react from 0.575.0 to 1.16.0 in /dashboard#108
Merged
Conversation
lucide-react v1 removed all brand icons. Replace the removed Github icon with an inline-SVG GithubIcon component, and add an aria-label to the footer link for an accessible name. Supersedes #73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
lucide-react0.575.0 → 1.16.0 in/dashboard. Supersedes #73.Breaking change in v1
lucide-react v1 removed all brand icons, including
Github. Across the 13 dashboard files importing lucide-react, only one symbol broke:GithubinLogin.tsx.Fix
dashboard/src/components/GithubIcon.tsx— inline SVG of the official GitHub mark. Filled path withfill="currentColor"so it inherits color from CSS exactly like the stroke-based lucide icon it replaced (no CSS changes needed).Login.tsx— swap<Github>for<GithubIcon>, and addaria-label="GitHub"to the footer link (it previously had no accessible name).Verification
npm run build(tsc + vite) — passes, zero errors.npm run lint— zero errors (3 pre-existing warnings in unrelated files).--text-mutednormally and--primaryon hover.