x-axis labels include years and are at the starts of months#79
Merged
NickGerleman merged 1 commit intorn-versions:mainfrom May 21, 2025
Merged
x-axis labels include years and are at the starts of months#79NickGerleman merged 1 commit intorn-versions:mainfrom
NickGerleman merged 1 commit intorn-versions:mainfrom
Conversation
Contributor
sophiebits
commented
May 15, 2025
sophiebits
commented
<img width="754" alt="screenshot of updated charts" src="https://github.com/user-attachments/assets/48870124-978b-499a-bdf6-047154b0d6a7" />
Contributor
Author
Collaborator
|
I do not remember this code at all, so I'm just going to trust 😀. Is there any overlap when the card is narrow, like on mobile? |
wojtekmaj
approved these changes
May 20, 2025
Contributor
wojtekmaj
left a comment
wojtekmaj
left a comment
There was a problem hiding this comment.
Verified and tested locally, looks good to me 👍
Contributor
|
@NickGerleman Nope, no overlap - just because the ticks are there doesn't mean the chart library must render them. But you can make it so that they touch :D 
|
Contributor
|
Nah it's just because the data is not up to date on this branch. |
Contributor
Author
|
Thanks both! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.