Update ExecuteJavascriptMiddleware.php by allowing config of waitUntilNetworkIdle()#202
Open
josezenem wants to merge 3 commits intoroach-php:mainfrom
Open
Update ExecuteJavascriptMiddleware.php by allowing config of waitUntilNetworkIdle()#202josezenem wants to merge 3 commits intoroach-php:mainfrom
josezenem wants to merge 3 commits intoroach-php:mainfrom
Conversation
Contributor
|
Sorry for the delay. Looks good to me, thanks for the contribution! Can you rebase your changes on top of |
Author
|
Of course, no problem thank you! i have updated and pushed, thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces an additional improvement to #56 by allowing the configuration of
waitUntilNetworkIdle(). The previous implementation assumed the true statement, making it impossible to overwrite this behavior without duplicating the class, which I ran into for a particular project.To address this, a new config variable called
waitUntilNetworkIdlehas been introduced. By default, the config is set to true to maintain backward compatibility with the original pull request. However, you now have the flexibility to overwrite the setting and set it to false.