Closed
Conversation
…eir readyAt times
Contributor
|
Thanks for the contribution, but I think I'll hold off of adding this to the package itself for now. This is something that can reasonably done in user space via an external package. Instead of extending the |
Author
|
Alright, seems fair. Thanks for the tips and checking it out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new scheduler that schedules requests based on their
readyAttimes. Scheduling requests this way makes retying with an exponential backoff a future possibility.TimedRequestScheduleruses a priority queue to sort requests based on theirreadyAttimes. If noreadyAttime is available, the current time is used.The order of requests with identical
readyAttimes cannot be guaranteed, due to the implemenation of the priority queue. Below is from the Php docs:Making this the default scheduler could potentially break backwards compatibility because of the undefined order.