Conversation
Add support for PHP 8.5 while maintaining backward compatibility with PHP 8.2, 8.3, and 8.4. Changes: - Update composer.json PHP version constraint to include ~8.5.0 - Update composer.lock with PHP 8.5 compatible dependencies - Add PHP 8.5 to GitHub Actions CI/CD test matrix - Fix PHPStan errors (offsetAccess.invalidOffset in Item.php) - Remove unnecessary phpstan-ignore annotation in RequestDeduplicationMiddleware - Update CHANGELOG.md for version 3.3.0 All tests passing on PHP 8.5.0 (502 tests, 808 assertions)
- Remove phpstan baseline errors by fixing type safety in Processor - Add explicit type checks for Request vs ItemInterface in middleware loop - Replace dynamic method invocation with conditional branches for clarity - Fix potential false return value handling in RequestDeduplicationMiddleware - Improve type hints with proper PHPDoc annotations for each branch - Clear phpstan-baseline.neon as all issues are now resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for PHP 8.5 while maintaining backward compatibility with PHP 8.2, 8.3, and 8.4.
Motivation
With PHP 8.5 now released, this update ensures Roach stays current with the latest PHP version and allows users to leverage new PHP 8.5 features and improvements in their web scraping projects.
Changes Made
Core Changes
composer.jsonPHP version constraint to include~8.5.0composer.lockwith PHP 8.5 compatible dependenciesCode Quality Improvements
offsetAccess.invalidOffseterror inItem.php@phpstan-ignoreannotation inRequestDeduplicationMiddleware.phpDocumentation
CHANGELOG.mdwith version 3.3.0 entryTesting
All tests pass successfully on PHP 8.5.0:
Backward Compatibility
✅ No breaking changes - Full backward compatibility maintained with PHP 8.2, 8.3, and 8.4
Checklist