update torch dependency for mac/linux compatibility#648
Open
Anxhela21 wants to merge 4 commits intoroad-core:mainfrom
Open
update torch dependency for mac/linux compatibility#648Anxhela21 wants to merge 4 commits intoroad-core:mainfrom
Anxhela21 wants to merge 4 commits intoroad-core:mainfrom
Conversation
Signed-off-by: Anxhela Coba <acoba@redhat.com>
tisnik
requested changes
Jul 9, 2025
Collaborator
tisnik
left a comment
There was a problem hiding this comment.
in order for tests to pass on CI, the lockfile should be generated for "default", "dev", and also probably "evaluation" groups (and now for "torch-linux"). It might fix CI failures.
Signed-off-by: Anxhela Coba <acoba@redhat.com>
This reverts commit 49d3cba.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In LCORE evaluation we are temporarily depending on road-core dependencies. The road-core service has hard requirement for torch version 2.7.0+cpu which is incompatible for mac (requires 2.6.0). In this PR we remove torch from main dependencies and instead define platform-specific versions under optional dependency group
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing