refactor: change describe page#264
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
vpikulik
force-pushed
the
refactor/container-details
branch
from
d2e9880 to
01d589a
Compare
|
|
||
| let scroll = self.resolve_scroll(&area.height, &n_lines); | ||
|
|
||
| let paragraph = paragraph.scroll((scroll, 0)); |
There was a problem hiding this comment.
Where does the scrolling logic go in this PR?
There was a problem hiding this comment.
Tree widget has own scrollbar https://github.com/robertpsoane/ducker/pull/264/changes#diff-2f128efa871d6ebd4adda2b933646bb7690356eac4d53e8401b3400bc9c58f49R193-R197
I hope this should be enough.
There was a problem hiding this comment.
It does have it's own scrollbar, however we need to handle the arrow key keypresses and tell it to scroll
If you describe a resource that doesn't fit on the page and attempt to scroll, nothing happens
There was a problem hiding this comment.
Sorry, for the long delay with the answer.
I checked: tree widget can have own scrollbar and can render it correctly, tree state somehow integrates scrollbar state and has methods scroll_up/down. I checked it locally - looks and works well) please have a look
There was a problem hiding this comment.
Thanks very much! I've just fixed the minor merge conflicts, then will merge!
vpikulik
force-pushed
the
refactor/container-details
branch
from
39806eb to
08dca7d
Compare
## 🤖 New release * `ducker`: 0.6.2 -> 0.6.3 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.6.3](v0.6.2...v0.6.3) - 2026-02-25 ### Other - change describe page ([#264](#264)) - *(deps)* bump chrono from 0.4.43 to 0.4.44 ([#286](#286)) - *(deps)* bump clap from 4.5.57 to 4.5.60 ([#285](#285)) - *(deps)* bump tempfile from 3.24.0 to 3.25.0 ([#284](#284)) - *(deps)* bump futures from 0.3.31 to 0.3.32 ([#283](#283)) - release v0.6.2 ([#280](#280)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
Preparing describe page to be enreached with addition data, like
container inspect. I would like to add first ENV variables to containers.tui-tree-widgetis usedDescribetrait to replace serde serialization of objects