Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 46.75% 47.19% +0.43%
==========================================
Files 2 2
Lines 509 659 +150
Branches 509 659 +150
==========================================
+ Hits 238 311 +73
- Misses 270 324 +54
- Partials 1 24 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Okay, calling However, it fails with This seems to be due to a misunderstanding of how Looking at its current implementation, So our implementation needs to be fixed to return the correct but undocumented error. |
|
The MSRV failure is still weird The error with 1.64 seems to be I don't see any changes that would allow this with 1.65 https://releases.rs/docs/1.65.0/ |
|
I don't understand why unsafe-in-unsafe caused an error when testing MSRV against 1.64 but not 1.65, but it's possibly best to postpone this to an edition update (and likely MSRV bump as well) which would make it fully supported |
|
TODO: This currently |
8863e06 to
5d6b5fc
Compare
|
Note that in but in the The |
Signed-off-by: robot9001 <robo9k@symlink.io>
References
#433 (comment)
Description
Implement
libmagic"parameters" - configuration values