setup: offer the agent's on-demand camera mode, defaulting to on_demand (#179) - #182
Open
Adityakk9031 wants to merge 4 commits into
Open
setup: offer the agent's on-demand camera mode, defaulting to on_demand (#179)#182Adityakk9031 wants to merge 4 commits into
Adityakk9031 wants to merge 4 commits into
Conversation
Contributor
Author
|
@jeqcho have a look |
Collaborator
|
Thanks @Adityakk9031! CI on this branch is green, but it now has merge conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179.
Problem
-P images=on_demand(#173, #175) allows theagentpolicy to issuetake_pictool calls for frames on-demand instead of attaching all camera frames to every observation. While this is cheaper and preferable for real rigs, it was only discoverable via the plugin README.inspect-robots setupis where operators configure defaults, but it previously did not prompt foragentpolicy options.Solution
_setup.py):_valid_images_mode()validator ("on_demand"/"always").configured_policy == "agent"that suggestson_demand(explaining the token savings vs model responsibility tradeoff) while preserving any existingimagesconfiguration in[policy.args]on setup re-runs._render_config()to render managed[policy.args]blocks alongside[defaults]and[embodiment.args]while preserving any unmanaged policy args.plugins/inspect-robots-agent/README.mdto note thatinspect-robots setupsuggestson_demandwhile preserving the library defaultalways.docs/guide/cli.mdanddocs/guide/quickstart.mdwizard descriptions.tests/test_setup.py):test_render_config_renders_policy_args.on_demand), explicit selection (always), and config preservation on setup re-runs.Verification
ruff check .— All checks passed.ruff format --check .— All 108 files formatted.pytest tests/test_setup.py— 105 passed, 16 skipped (POSIX/symlink-gated tests skipped on Windows as expected).