Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to mark the :shadows:httpclient module as deprecated. The changes in docs/using-add-on-modules.md correctly reflect this by updating the comment in the 'Deprecated packages' table to mention the deprecation in Robolectric 4.17 and adding a link to the release notes. The changes are accurate and well-implemented. I have no further feedback.
Member
Author
|
I've marked this as draft until we have at least a beta version of Robolectric 4.17. |
This commit properly marks the `:shadows:httpclient` module as deprecated.
MGaetan89
force-pushed
the
deprecate-shadows-httpclient
branch
from
6e4c95a to
91e9695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit properly marks the
:shadows:httpclientmodule as deprecated.