feat: Add starship prompt integration (rebased on uat)#112
Conversation
…izard Write a ready-to-go ~/.bishrc with starship prompt support (guarded by `command -v starship`) during first-time setup, so new users get a rich prompt out of the box. Existing ~/.bishrc files are left untouched (append-only for the config_ui source line). Add starship as a dependency/recommendation across all packaging formats. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… integration Fixes critical error handling bugs and improves starship integration clarity. Error Handling Fixes (internal/wizard/embed.go): - Add errors.Join import for proper error composition - Fix defer pattern that tried to assign to non-named return value - Properly combine write and close errors using errors.Join - Ensures close errors are not silently dropped Starship Integration Improvements (bishrc.template): - Remove STARSHIP_START_TIME (not needed, bishop tracks duration internally) - Add detailed comments explaining integration mechanism - Document that BISH_UPDATE_PROMPT() is called automatically - Clarify that bishop provides BISH_LAST_COMMAND_EXIT_CODE and BISH_LAST_COMMAND_DURATION_MS - Add quotes around variable expansions for safety - Set initial prompt with explicit values (status=0, cmd-duration=0) Addresses blocking issues from PR review: - Named return value issue (line 23) - Incorrect defer pattern (lines 48-52) - Starship integration correctness and documentation Build Status: ✅ All tests passing ✅ golangci-lint: 0 issues ✅ govulncheck: no vulnerabilities ✅ Binary compiled successfully
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c84ab2ce84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| version "0.22.2" | ||
| license "GPL-3.0-or-later" | ||
|
|
||
| depends_on "starship" |
There was a problem hiding this comment.
Adding depends_on "starship" makes Homebrew treat starship as mandatory, so brew install bish can now fail in environments where starship is unavailable (for example restricted mirrors/private taps) even though bishop itself already handles missing starship at runtime (if command -v starship in internal/wizard/bishrc.template). This regresses installation reliability by turning an optional prompt enhancement into an install-time blocker.
Useful? React with 👍 / 👎.
1 participant
Rebased starship-wizard-integration branch onto uat.
This PR adds starship prompt integration to the wizard setup while keeping starship optional:
Resolves conflicts from previous integration work, maintaining the optional starship design from main while applying wizard fixes.