Open
Conversation
…eturn newly created jobid for reference
…st before adding it,avoiding another addon add again same cron; make Id fix and part of job line in xml, no more changing id, addon can keep their jobid in their config for deleting or updating it later
Refresh readme for including new feature: - now the cron.xml is indented correctly (all was on only one line before) - now addJob method return jobId for giving capability to addon caller to keep this id for reuse later - now check if command + expression already exist before adding it. If already exist do nothing (and add a warning in xbmc logs) - all this give the possibility for addon to update an already defined cron
Owner
|
Wow, thanks for all the work. I'll go through all this in detail over the next day or two but based on the descriptions I like the additions here. Thanks! |
Author
|
warning don't merge, i just realized i forgot to change UI for job.ID change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made lot of improvement, don't know if you're interested in. Feel free to merge or refuse:
utils.logusexbmc.login placeSeems to work fine on my kodi