Skip to content

Add path parameter to IPASizeProvider#74

Open
wacumov wants to merge 3 commits intorockbruno:masterfrom
wacumov:master
Open

Add path parameter to IPASizeProvider#74
wacumov wants to merge 3 commits intorockbruno:masterfrom
wacumov:master

Conversation

@wacumov
Copy link
Copy Markdown

@wacumov wacumov commented Oct 5, 2021

Fixes #64.

Copy link
Copy Markdown
Contributor

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wacumov thanks for your contribution!
Could you update the tests for this new feature? 😊🙏

Copy link
Copy Markdown
Contributor

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks once again 🎉
@rockbruno gonna leave the final review for you 💪

@@ -1,9 +1,16 @@
import Foundation

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

***eezy12
login

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updated to use the output_directory from gym if provided

3 participants