Skip to content

fix(vxfw): out of bounds panic on ScrollBars #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockorager merged 1 commit into from
May 25, 2026
Merged

fix(vxfw): out of bounds panic on ScrollBars #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vxfw/ScrollBars.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ pub fn handleCapture(self: *ScrollBars, ctx: *vxfw.EventContext, event: vxfw.Eve

// If the new thumb position is at the top we know we've scrolled to the top of
// the scroll view.
if (new_thumb_top == 0) {
if (new_thumb_top <= 0) {
self.scroll_view.scroll.top = 0;
return ctx.consumeAndRedraw();
}
Expand Down Expand Up @@ -238,7 +238,7 @@ pub fn handleCapture(self: *ScrollBars, ctx: *vxfw.EventContext, event: vxfw.Eve

// If the new thumb position is at the horizontal beginning of the current view
// we know we've scrolled to the beginning of the scroll view.
if (new_thumb_col_start == 0) {
if (new_thumb_col_start <= 0) {
self.scroll_view.scroll.left = 0;
return ctx.consumeAndRedraw();
}
Expand Down
Loading