Open
Conversation
This method was getting pretty hard to follow.
rogueg
reviewed
Mar 30, 2020
Comment on lines
+41
to
+58
| // host worker and head | ||
| app.use(async (req, resp, next) => { | ||
| let pageType | ||
| if (req.url.match(/^\/worker/)) { | ||
| pageType = 'worker' | ||
| } else { | ||
| const pathname = req._parsedUrl.pathname | ||
| if (pathname.match(/^\/(index(\.htm(l)?)?)?$/)) { | ||
| pageType = 'head' | ||
| } | ||
| } | ||
|
|
||
| if (pageType) { | ||
| resp.end(Zen.indexHtml(pageType)) | ||
| } else { | ||
| next() | ||
| } | ||
| }) |
Owner
There was a problem hiding this comment.
This seems much bigger than the 1 line it was previously.
Collaborator
Author
There was a problem hiding this comment.
As far as I can tell the previous 1 line was sending head.js to any request that failed to match a route. This new code should send a 404 if an unknown asset is requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method was getting pretty hard to follow.