Skip to content

More correct error message, issue #328 #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonasbn merged 2 commits into from
Mar 14, 2026
+4 −6
Merged

More correct error message, issue #328 #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b685a5
Addressing issue #328, cleaned up the error message, to be more corre…
jonasbn Mar 10, 2026
ea20c13
Preparing release
jonasbn Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

- Docker based image updated for Python 3.14.3 slim trixie via PR [#325](https://github.com/rojopolis/spellcheck-github-actions/pull/325) from Dependabot.

- Cleaned up the error messaging, to address issue [#328](https://github.com/rojopolis/spellcheck-github-actions/issues/328) from @akohout-hai, the error message is now more correct, but not improved in general

## 0.59.0, 2026-03-02, feature release, update recommended

- Improvements have been added to the docker entrypoint, based on a PR from @akohout-hai which fixes an issue with handling of spaces in files names and directories, see PR [#322](https://github.com/rojopolis/spellcheck-github-actions/pull/322) for details. This is his first contribution to the project and I want to thank him for his contribution, which is highly appreciated.
Expand Down
8 changes: 2 additions & 6 deletions entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,13 +177,9 @@ fi
echo "----------------------------------------------------------------"

if [ -n "$GITHUB_ACTIONS" ]; then
test "$EXITCODE" -gt 1 && echo "::error title=Spelling check::Spelling check action failed, please check diagnostics";

test "$EXITCODE" -eq 1 && echo "::error title=Spelling errors::Files in repository contain spelling errors";
test "$EXITCODE" -gt 0 && echo "::error title=Error::Files in repository contain spelling errors or or spelling check action failed, please check diagnostics";
else
test "$EXITCODE" -gt 1 && echo "Spelling check action failed, please check diagnostics";

test "$EXITCODE" -eq 1 && echo "Files in repository contain spelling errors";
test "$EXITCODE" -gt 0 && echo "Files in repository contain spelling errors or spelling check action failed, please check diagnostics";
fi

exit "$EXITCODE"