Skip to content

fix(examples): allow propagation on key event#340

Open
joepie91 wants to merge 1 commit intoromgrk:masterfrom
joepie91:joepie91-patch-1
Open

fix(examples): allow propagation on key event#340
joepie91 wants to merge 1 commit intoromgrk:masterfrom
joepie91:joepie91-patch-1

Conversation

@joepie91
Copy link

@joepie91 joepie91 commented Feb 4, 2023

Seems that it's actually required to return a boolean value from at least this event handler (I assume the same is true for others). Otherwise, it produces the following error:

TypeError: Cannot convert value "undefined" to type gboolean in signal "key-press-event"
    at Object.main (/home/sven/projects/_3rdparty/node-gtk/lib/overrides/Gtk-3.0.js:45:9)
    at Function.<anonymous> (/home/sven/projects/_3rdparty/node-gtk/examples/entry.js:44:7)
    at Object.<anonymous> (/home/sven/projects/_3rdparty/node-gtk/examples/entry.js:50:8)
    at Module._compile (node:internal/modules/cjs/loader:1155:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1209:10)
    at Module.load (node:internal/modules/cjs/loader:1033:32)
    at Function.Module._load (node:internal/modules/cjs/loader:868:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
    at node:internal/main/run_main_module:22:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant