Closed
Conversation
Contributor
|
@romgrk, it was needed for V8ToGIArgument to make it work on Windows, maybe it's not needed for V8ToOutGIArgument, I never faced such an issue. |
Contributor
|
BTW, I created #336 some time ago, not sure why it got closed. I also update actions and readme, take a look at https://github.com/ten0s/node-gtk |
Owner
Author
|
Neat, didn't saw, haven't been around much. Do you wanna re-open that PR? Is it ready to be merged? |
Contributor
|
error.js failed on Windows. Not sure why. It worked back then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt for node 18 & 20 changes.