Espace « Mes partages » pour l'invité (#273)#359
Merged
Conversation
…cès invité à /partages (#273)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Résumé
/mes-partageslistant, pour l'utilisateur connecté, lesShareactifs (non révoqués, non expirés) dont il est le destinataire (guest) — jusqu'ici la seule porte d'entrée était le lien contenu dans l'email de notification.ShareRepository::findActiveByGuest(): requête filtrée guest + active, triée par date décroissante. Aucune migration Doctrine (l'indexidx_share_lookupcouvrait déjà le besoin).MyReceivedSharesWebController(lecture seule) +templates/web/my_received_shares.html.twig, réutilisant le patternresolveResourceName/redirectUrlForexistant dansShareWebController.{% if app.user.isGuest %}ajouté à la sidebar./partages(dédiée à l'owner) ; partages expirés/révoqués exclus (pas grisés) ; route accessible à un comptefullmais toujours liste vide (pas de 403).ShareWebControllerqui affirmait à tort qu'un guest n'avait pas accès à/partages.Closes #273
Test plan
./vendor/bin/phpunit --filter ShareRepositoryTest— 7 tests (isolation guest, exclusion expiré/révoqué, vide, tri)./vendor/bin/phpunit --filter MyReceivedSharesWebTest— 11 tests (accès non autorisé, happy path, cas limites, lien nav)./vendor/bin/phpunit— 940 tests, GREENcomposer build-assets(Tailwind) relancé après modification des templates