Allow subclasses to override how the token is generated.#5
Open
mfn wants to merge 1 commit intoronnylt:masterfrom
Open
Allow subclasses to override how the token is generated.#5mfn wants to merge 1 commit intoronnylt:masterfrom
mfn wants to merge 1 commit intoronnylt:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
uniqid()in high frequency environments can pose a problem because the entropy isn't very high. It didn't took my long with a few processes and low ttls to encounter duplicate values returned fromuniqid()in different processes.One optimization could be to use the second parameter for high entropy, e.g.
uniqid("", true);but instead of hardcoding it, I felt the flexibility of being able to override how it is generated better serves the community.