Skip to content

[core] Follow symlinks in TROOT::GetSharedLibDir() #21033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guitargeek merged 1 commit into from
Jan 27, 2026
Merged

[core] Follow symlinks in TROOT::GetSharedLibDir() #21033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion core/base/src/TROOT.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3159,7 +3159,26 @@ const TString &TROOT::GetSharedLibDir()

fs::path p = info->dlpi_name;
if (p.filename() == _R_QUOTEVAL_(LIB_CORE_NAME)) {
libdir = p.parent_path().c_str();
std::error_code ec;

// Resolve symlinks: critical for environments like CMSSW, where the
// ROOT libraries are loaded via symlinks that point to the actual
// install directory
fs::path resolved = fs::canonical(p, ec);
if (ec) {
::Error("TROOT",
"Failed to canonicalize detected ROOT shared library path:\n"
"%s\n"
"Error code: %d (%s)\n"
"Error category: %s\n"
"This is an unexpected internal error and ROOT might not work.\n"
"Please report this issue on GitHub: https://github.com/root-project/root/issues",
p.string().c_str(), ec.value(), ec.message().c_str(), ec.category().name());
// Fall back to the loader path if canonicalization fails. The path
// will likely be wrong, but at least not garbage
resolved = p;
}
libdir = resolved.parent_path().c_str();
return 1; // stop iteration
}
return 0; // continue
Expand Down
Loading