[nfc][cmake] mention that some builtins are no longer bundled by ferdymercury · Pull Request #21596 · root-project/root

ferdymercury · 2026-03-13T11:55:41Z

but require internet connection

github-actions · 2026-03-13T14:54:49Z

Test Results

0 tests 0 ✅ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 1fcbce6.

♻️ This comment has been updated with latest results.

dpiparo · 2026-03-15T11:52:56Z

Thanks. When zstd is merged #21597 and zlib is added to the bundle, this will be merged (and maybe topped up with lzma, which is treated the same.
This nice doc will be complemented with something more substantial in the Release Notes and in the repository as well, to give a clear and simple overview of what builtins are used and what is their version.

ferdymercury · 2026-03-16T14:33:16Z

Thanks for the feedback Danilo :)

btw, builtin_xxhash looks like another candidate for off-loading to LCG, in the context of compression

silverweed · 2026-03-18T13:29:46Z

btw, builtin_xxhash looks like another candidate for off-loading to LCG, in the context of compression

AFAIK the policy is to keep anything that is strictly required to build minimal ROOT as vendored code and xxhash is one such dependency (required e.g. to build RNTuple)

hageboeck · 2026-03-27T09:13:49Z

btw, builtin_xxhash looks like another candidate for off-loading to LCG, in the context of compression

AFAIK the policy is to keep anything that is strictly required to build minimal ROOT as vendored code and xxhash is one such dependency (required e.g. to build RNTuple)

I think we are about to abandon this policy. For things that are readily available in most Linuxes and in homebrew, we suggest, in order of preference:

Get it from the system
Compile and install it to a custom location and make CMake aware of it (e.g. using CMAKE_PREFIX_PATH)
Ask ROOT to download the builtin (requires network)
[Not implemented yet] Provide a folder that contains the required tarballs. We are considering a config option that would tell ROOT where to pick up the tarballs.

Only option 3 requires network during the configure step. All others could be performed offline.

ferdymercury · 2026-04-07T14:01:49Z

cmake/modules/RootBuildOptions.cmake

 ROOT_BUILD_OPTION(builtin_unuran OFF "Build bundled copy of unuran")
 ROOT_BUILD_OPTION(builtin_vdt OFF "Build VDT internally (requires network)")
 ROOT_BUILD_OPTION(builtin_xrootd OFF "Build XRootD internally (requires network)")
 ROOT_BUILD_OPTION(builtin_xxhash OFF "Build bundled copy of xxHash")


Suggested change

ROOT_BUILD_OPTION(builtin_xxhash OFF "Build bundled copy of xxHash")

ROOT_BUILD_OPTION(builtin_xxhash OFF "Build xxHash internally (requires network)")

To apply if #21806 gets merged

ferdymercury · 2026-04-09T07:59:28Z

cmake/modules/RootBuildOptions.cmake

 ROOT_BUILD_OPTION(builtin_nlohmannjson OFF "Use nlohmann/json.hpp file distributed with ROOT")
 ROOT_BUILD_OPTION(builtin_openssl OFF "Build OpenSSL internally (requires network)")
 ROOT_BUILD_OPTION(builtin_openui5 ON "Use openui5 bundle distributed with ROOT")
 ROOT_BUILD_OPTION(builtin_pcre OFF "Build bundled copy of PCRE")


Suggested change

ROOT_BUILD_OPTION(builtin_pcre OFF "Build bundled copy of PCRE")

ROOT_BUILD_OPTION(builtin_pcre OFF "Build PCRE2 internally (requires network)")

If #21857 gets merged

but require internet connection [cmake] two more

ferdymercury · 2026-04-12T12:50:54Z

cmake/modules/RootBuildOptions.cmake

 ROOT_BUILD_OPTION(builtin_ftgl OFF "Build bundled copy of FTGL")
-ROOT_BUILD_OPTION(builtin_gif OFF "Build bundled copy of libgif")
+ROOT_BUILD_OPTION(builtin_gif OFF "Build libgif internally (requires network)")
 ROOT_BUILD_OPTION(builtin_gl2ps OFF "Build bundled copy of gl2ps")


Suggested change

ROOT_BUILD_OPTION(builtin_gl2ps OFF "Build bundled copy of gl2ps")

ROOT_BUILD_OPTION(builtin_gl2ps OFF "Build gl2ps internally (requires network)")

depending on #21895

ferdymercury · 2026-04-12T12:51:45Z

README/ReleaseNotes/v640/index.md

+* The previously vendored builtins `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2` and `openssl` should be installed in the system if possible. ROOT will not automatically fall-back to their builtin versions if these are not found: the user is informed of that with a helpful message. If installing these dependencies in the system is not possible, the CMake option `-Dbuiltin_XYZ=ON` has to be consciously chosen by the user.
+* For the builtin versions of `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2`, the source tarballs are now fetched from [SPI](https://spi.web.cern.ch)'s [website](https://lcgpackages.web.cern.ch/), as for the vast majority of ROOT's builtins, e.g. `openssl` or `xrootd`.


Suggested change

* The previously vendored builtins `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2` and `openssl` should be installed in the system if possible. ROOT will not automatically fall-back to their builtin versions if these are not found: the user is informed of that with a helpful message. If installing these dependencies in the system is not possible, the CMake option `-Dbuiltin_XYZ=ON` has to be consciously chosen by the user.

* For the builtin versions of `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2`, the source tarballs are now fetched from [SPI](https://spi.web.cern.ch)'s [website](https://lcgpackages.web.cern.ch/), as for the vast majority of ROOT's builtins, e.g. `openssl` or `xrootd`.

* The previously vendored builtins `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2`, `ftgl`, `gl2ps` and `openssl` should be installed in the system if possible. ROOT will not automatically fall-back to their builtin versions if these are not found: the user is informed of that with a helpful message. If installing these dependencies in the system is not possible, the CMake option `-Dbuiltin_XYZ=ON` has to be consciously chosen by the user.

* For the builtin versions of `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2`, `ftgl`, `gl2ps`, the source tarballs are now fetched from [SPI](https://spi.web.cern.ch)'s [website](https://lcgpackages.web.cern.ch/), as for the vast majority of ROOT's builtins, e.g. `openssl` or `xrootd`.

ferdymercury · 2026-04-12T19:58:33Z

cmake/modules/RootBuildOptions.cmake

 ROOT_BUILD_OPTION(builtin_fftw3 OFF "Build FFTW3 internally (requires network)")
-ROOT_BUILD_OPTION(builtin_freetype OFF "Build bundled copy of freetype")
+ROOT_BUILD_OPTION(builtin_freetype OFF "Build freetype internally (requires network)")
 ROOT_BUILD_OPTION(builtin_ftgl OFF "Build bundled copy of FTGL")


Suggested change

ROOT_BUILD_OPTION(builtin_ftgl OFF "Build bundled copy of FTGL")

ROOT_BUILD_OPTION(builtin_ftgl OFF "Build FTGL internally (requires network)")

if #21898 goes in

ferdymercury changed the title ~~[skip-ci][cmake] mention that builtins are no longer bundled~~ [nfc][cmake] mention that builtins are no longer bundled Mar 13, 2026

ferdymercury marked this pull request as ready for review March 13, 2026 11:56

ferdymercury requested a review from bellenot as a code owner March 13, 2026 11:56

ferdymercury changed the title ~~[nfc][cmake] mention that builtins are no longer bundled~~ [nfc][cmake] mention that some builtins are no longer bundled Mar 13, 2026

ferdymercury added the skip ci Skip the full builds on the actions runners label Mar 13, 2026

vepadulano assigned dpiparo Mar 14, 2026

ferdymercury added the pr:squash on merge label Mar 24, 2026

ferdymercury requested a review from hageboeck March 27, 2026 07:56

ferdymercury mentioned this pull request Mar 27, 2026

[RelNotes] Phrase the section about builtins in a "system first" manner. #21711

Merged

ferdymercury requested a review from dpiparo March 31, 2026 05:58

ferdymercury commented Apr 7, 2026

View reviewed changes

ferdymercury commented Apr 9, 2026

View reviewed changes

[cmake] mention that builtins are no longer bundled

434740e

but require internet connection [cmake] two more

ferdymercury force-pushed the patch-5 branch from 721c259 to 434740e Compare April 12, 2026 11:50

[nfc] update release notes

1fcbce6

ferdymercury commented Apr 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nfc][cmake] mention that some builtins are no longer bundled#21596

[nfc][cmake] mention that some builtins are no longer bundled#21596
ferdymercury wants to merge 2 commits intoroot-project:masterfrom
ferdymercury:patch-5

ferdymercury commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

dpiparo commented Mar 15, 2026

Uh oh!

ferdymercury commented Mar 16, 2026

Uh oh!

silverweed commented Mar 18, 2026

Uh oh!

hageboeck commented Mar 27, 2026

Uh oh!

ferdymercury Apr 7, 2026

Uh oh!

ferdymercury Apr 9, 2026

Uh oh!

ferdymercury Apr 12, 2026

Uh oh!

ferdymercury Apr 12, 2026 •

edited

Loading

Uh oh!

ferdymercury Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	ROOT_BUILD_OPTION(builtin_xxhash OFF "Build bundled copy of xxHash")
	ROOT_BUILD_OPTION(builtin_xxhash OFF "Build xxHash internally (requires network)")

	ROOT_BUILD_OPTION(builtin_pcre OFF "Build bundled copy of PCRE")
	ROOT_BUILD_OPTION(builtin_pcre OFF "Build PCRE2 internally (requires network)")

	ROOT_BUILD_OPTION(builtin_gl2ps OFF "Build bundled copy of gl2ps")
	ROOT_BUILD_OPTION(builtin_gl2ps OFF "Build gl2ps internally (requires network)")

		* The previously vendored builtins `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2` and `openssl` should be installed in the system if possible. ROOT will not automatically fall-back to their builtin versions if these are not found: the user is informed of that with a helpful message. If installing these dependencies in the system is not possible, the CMake option `-Dbuiltin_XYZ=ON` has to be consciously chosen by the user.
		* For the builtin versions of `freetype`, `xxhash`, `zlib`, `lzma`, `zstd`, `lz4`, `libpng`, `giflib`, `libjpeg`, `pcre2`, the source tarballs are now fetched from [SPI](https://spi.web.cern.ch)'s [website](https://lcgpackages.web.cern.ch/), as for the vast majority of ROOT's builtins, e.g. `openssl` or `xrootd`.

	ROOT_BUILD_OPTION(builtin_ftgl OFF "Build bundled copy of FTGL")
	ROOT_BUILD_OPTION(builtin_ftgl OFF "Build FTGL internally (requires network)")

Conversation

ferdymercury commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

dpiparo commented Mar 15, 2026

Uh oh!

ferdymercury commented Mar 16, 2026

Uh oh!

silverweed commented Mar 18, 2026

Uh oh!

hageboeck commented Mar 27, 2026

Uh oh!

ferdymercury Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

ferdymercury Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

ferdymercury Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

ferdymercury Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ferdymercury Apr 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Mar 13, 2026 •

edited

Loading

ferdymercury Apr 12, 2026 •

edited

Loading