[graphics] fix none-opaque moving and resizing#21887
Merged
linev merged 10 commits intoroot-project:masterfrom Apr 14, 2026
Merged
[graphics] fix none-opaque moving and resizing#21887linev merged 10 commits intoroot-project:masterfrom
linev merged 10 commits intoroot-project:masterfrom
Conversation
linev
changed the title
Test Results 22 files 22 suites 3d 4h 2m 22s ⏱️ Results for commit 8b7a638. ♻️ This comment has been updated with latest results. |
Use PaintArrowNDC in the TArrow::Paint Use attributes ModifyOn methods Shorten options handling code
When disabled, drawing performed on complete canvas. So one should use absolute coordinates for painting. While such situation appears in interactive painting, support for now only line and box drawing
Let work resize/move of TBox in not-opaque mode
While such mode is not default, it was not working since a long time. Now repair logic when and how coordiantes are set back
Similar as TBox
Like for TBox or TLine mode was not tested for long time and therefore not working
Handle all resize corners, resize sides and moving similar
linev
force-pushed
the
fix_nonopaque_moving
branch
from
9b27224 to
03879a0
Compare
Like in TBox, use enum and current coordinates Avoid first painting over original coordinates while this make invert drawing wrong
linev
force-pushed
the
fix_nonopaque_moving
branch
from
03879a0 to
d2440c3
Compare
Even it will not be used - for symmetry such events should be provided to TCanvas Co-authored-by: Bertrand Bellenot <Bertrand.Bellenot@cern.ch>
Events handling can be continued also when mouse already outside canvas. Therefore keep feedback mode as is. It will be switched off/on when needed by starting objects dragging or by start painting
couet
approved these changes
Apr 14, 2026
Member
|
Ok for me also. I just tried you branch on my mac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mode when not complete re-drawing of the pad is performed during object moving but just inverted painting of graphics primitives like line or box. While such mode is not default - it was not tested for long time and did not work properly
Adjust for prove of concept:
TLine::ExecuteEventTBox::ExecuteEventTPad::ExecuteEventTo properly handle non-opaque moving and resizing.
Also significantly simplify logic for
TBoxandTPadand significantly reduce number of static variables there.Provide mouse enter events for TCanvas - making symmetric with mouse leave events.
Disable toggling of feedback mode when leave canvas - while events processing can continue.
Attached is macro showing use of non-opaque mode:
hist.C.txt