[math] migrate old Makefiles to CMake and reenable non-covered tests#21890
[math] migrate old Makefiles to CMake and reenable non-covered tests#21890ferdymercury wants to merge 18 commits intoroot-project:masterfrom
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 6db032a. ♻️ This comment has been updated with latest results. |
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
linev
left a comment
There was a problem hiding this comment.
There are three points in smatrix/test/ subdirectory:
- Do we need test reflex dictionaries
- Is linking with CLHEP library crucial, do it properly
- How to use old ROOT files stored in the directory
math/smatrix/test/CMakeLists.txt
Outdated
| target_link_directories(${testname} PRIVATE "${CLHEPBASE}/lib") | ||
| endif() | ||
| endif() | ||
| ROOT_ADD_TEST(smatrix-${testname} COMMAND ${testname} LABELS ${${testname}_LABELS}) |
There was a problem hiding this comment.
There are two ROOT files in the directory which were generated by the tests.
One should try use these files for tests.
Most probably one need to make custom ROOT_ADD_TEST commands providing file name as argument
There was a problem hiding this comment.
you mean checking that the result generated by the test is compatible with that reference?
they get recreated at every run. so i guess that reference was done on an old SLC3 and gcc3
There was a problem hiding this comment.
Yes, we can extend testOperations.cxx and try to read old files as well.
No idea whether those things are relevant, I just reenabled something that was there. If not relevant, we should just delete the whole test :) |
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
as suggested by linev Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Co-authored-by: Philippe Canal <pcanal@fnal.gov>
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
Split-off #21820 as requested by @pcanal and @linev